Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the obj property which can be assigned additional properties #336

Closed

Conversation

silverbucket
Copy link

@silverbucket silverbucket commented Apr 16, 2021

Fixes #335

@kernc kernc force-pushed the master branch 3 times, most recently from 456869b to 94d26e8 Compare June 25, 2024 20:37
@silverbucket
Copy link
Author

@kernc can we merge this?

@kernc
Copy link
Member

kernc commented Dec 29, 2024

@silverbucket Apologies for the long turnaround. I follow the saying, when in doubt, defer. 😅 I understand you found this workaround when you weren't able to assign new attributes to pdoc documentation objects directly due to our use of __slots__?

__slots__ = ('module', 'name', 'obj', 'docstring', 'inherits')

In that case, with Python becoming leaner in the recent years, I'm questioning the (ancient) use of __slots__ and would probably prefer to simply remove the line ...

@silverbucket silverbucket closed this by deleting the head repository Feb 5, 2025
kernc added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Custom attributes to HTML templates
2 participants