BUG: Handle URLs with non-ASCII chars w/ --http #348
+392
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 allows Unicode identifiers, so non-ASCII characters should be handled with care. This commit fixes a bug that only happens when serving with `--http` (works fine when generating static HTML files). Before this fix, pydoc would raise errors if the URL contains non-ASCII module names.
kernc
force-pushed
the
master
branch
3 times, most recently
from
456869b
to
94d26e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 allows Unicode identifiers, so non-ASCII characters should be
handled with care.
This commit fixes a bug that only happens when serving with
--http(works fine when generating static HTML files). Before this fix, pydoc
would raise errors if the URL contains non-ASCII module names.