Ig 130 #136
Open
Ig 130 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdybowski
requested changes
May 20, 2022
|
|
||
| export const LoginPage = (): JSX.Element => { | ||
| export const LoginPage = (): any => { |
There was a problem hiding this comment.
dont have to set return type here
| // TODO display notification from context | ||
| console.log(error?.response.data || error?.response.status); | ||
| return addNotification({ | ||
| mode: NotificationMode.INFO, |
| return addNotification({ | ||
| mode: NotificationMode.INFO, | ||
| title: 'Login', | ||
| message: error, |
| try { | ||
| // TODO save user data to reducer | ||
| const userData = (await api.post('url..', form)) as User; | ||
| const userData = (await api.post('/login', form)) as User; |
|
|
||
| const login = async () => { | ||
| setIsLoading(true); |
|
|
||
| async function register() { | ||
| setLoading(true); | ||
| try { | ||
| // TODO save user data to reducer | ||
| const userData = (await api.post('url...', form)) as User; | ||
| const userData = (await api.post('/register', form)) as User; |
There was a problem hiding this comment.
check login component comments and fix ALL register
| try { | ||
| // TODO save user data to reducer | ||
| const userData = (await api.post('url..', form)) as User; | ||
| const userData = (await api.post('/login', form)) as User; |
There was a problem hiding this comment.
use generic types for POST
we want to declare with post requset will return
//
post method in api class should return Promise
| setLocalStorage(USER_TOKEN, userData.token); | ||
| dispatch(saveUserDataAction(form)); |
There was a problem hiding this comment.
we want to store userData that comes from api (check api response). not form. PASSWORD and token cannot be stored here :p
| try { | ||
| // TODO save user data to reducer | ||
| const userData = (await api.post('url..', form)) as User; | ||
| const userData = (await api.post('/login', form)) as User; | ||
| setLocalStorage(USER_TOKEN, userData.token); |
There was a problem hiding this comment.
token doesnt exist in userData. its different (check response)
| import { User } from '../../models/user'; | ||
| import { SAVE_USER_DATA } from '../actions/userActions'; | ||
|
|
||
| const initUserState: User = new User(); |
There was a problem hiding this comment.
we dont want initUserState. or if you want to just empty object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.