Add activity typeId filtering #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxsx
approved these changes
May 29, 2022
Co-authored-by: Bart Skowron <[email protected]>
|
@bxsx Appreciate the feedback, will look into adding a test when I have some time. |
Co-authored-by: Bart Skowron <[email protected]>
pe-st
added a commit
that referenced
this pull request
Jul 27, 2022
See also comment <#72 (comment)>
|
@joetimmerman I had to slightly adapt your code while rebasing, it's now part of the next version, see #104 |
|
Cheers, thanks for keeping this repo going. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to filter based on typeIds as requested in #71. The new --type_filter argument allows you to pass a list of typeIds and only pull activities matching those Ids.
For example:
$ python gcexport.py -tf 3Results in:
Filtering out due to typeID, 1 not in [3] : Garmin Connect activity (1/1) [8791243351