Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): abort expanding recurring events when end is reached #35

Closed
wants to merge 1 commit into from

Conversation

tripodsan
Copy link

fixes #34

  • the fix extends the parser by allowing to specify the desired start end end range.
  • recurring events are expanded until:
    1. completed, or
    2. when reaching the specified end range
    3. or 10 times, when no end range is specified

@movd
Copy link

movd commented May 4, 2020

could this please be merged?

@antosan
Copy link
Contributor

antosan commented May 27, 2021

Thank you @tripodsan for your PR. While reviewing we noticed that the implementation of the parser regarding the expansion was a little buggy. We expanded all the events from the start date and had to filter them again afterwards. We refactored this buggy behaviour in the parser and took into consideration your suggestions as well in #48.

@antosan antosan closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurring events not expanded to full range
3 participants