Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphanumeric housenumber test improvements #568

Merged
merged 6 commits into from
Jan 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{
"name": "Alphanumeric housenumbers",
"priorityThresh": 5,
"name": "Search Alphanumeric housenumbers",
"priorityThresh": 1,
"normalizers": {
"name": [
"toLowerCase"
],
"housenumber": [
"toLowerCase"
"toLowerCase",
"stripPunctuation"
],
"street": [
"toLowerCase"
Expand Down Expand Up @@ -89,15 +90,15 @@
"id": 3,
"status": "pass",
"in": {
"text": "15А Комсомольская улица minsk belarus"
"text": "15А Камсамольская вуліца minsk belarus"
},
"description": "Belarusian address written the localized way. Note the Cyrillic character in the query and expected result",
"issue": "https://github.com/pelias/pelias/issues/833",
"expected": {
"properties": [
{
"housenumber": "15А",
"street": "Комсомольская улица",
"street": "Камсамольская вуліца",
"region": "Minsk",
"country_a": "BLR"
}
Expand All @@ -108,15 +109,15 @@
"id": "3.1",
"status": "pass",
"in": {
"text": "Комсомольская улица 15А minsk belarus"
"text": "Камсамольская вуліца 15А minsk belarus"
},
"description": "Belarusian address written the 'American' way. Note the Cyrillic character in the query and expected result",
"issue": "https://github.com/pelias/pelias/issues/833",
"expected": {
"properties": [
{
"housenumber": "15А",
"street": "Комсомольская улица",
"street": "Камсамольская вуліца",
"region": "Minsk",
"country_a": "BLR"
}
Expand Down Expand Up @@ -177,6 +178,113 @@
}
]
}
},
{
"id": 6,
"status": "pass",
"in": {
"text": "kinkerstraat 175F, amsterdam"
},
"description": "Dutch address in a building with housenumbers like 175A, 175B, 175C, etc. Without proper sorting the desired result can easily be drowned out",
"expected": {
"properties": [
{
"housenumber": "175F",
"street": "Kinkerstraat",
"locality": "Amsterdam",
"country_a": "NLD"
}
]
}
},
{
"id": "6.1",
"status": "fail",
"in": {
"text": "kinkerstraat 175 F, amsterdam"
},
"description": "As above, we currently dont support permutations of the unit number, as in this example with a space",
"expected": {
"properties": [
{
"housenumber": "175F",
"street": "Kinkerstraat",
"locality": "Amsterdam",
"country_a": "NLD"
}
]
}
},
{
"id": 7,
"status": "pass",
"in": {
"text": "Vanadiumweg 11C, Amersfoort"
},
"description": "Dutch address in a building with housenumbers like 175A, 175B, 175C, etc. Without proper sorting the desired result can easily be drowned out",
"expected": {
"properties": [
{
"housenumber": "11C",
"street": "Vanadiumweg",
"locality": "Amersfoort",
"country_a": "NLD"
}
]
}
},
{
"id": "7.1",
"status": "pass",
"in": {
"text": "Vanadiumweg 11, Amersfoort"
},
"description": "Expect the housenumber 11 (with no unit suffix) to appear before those with a unit suffix",
"expected": {
"properties": [
{
"housenumber": "11",
"street": "Vanadiumweg",
"locality": "Amersfoort",
"country_a": "NLD"
}
]
}
},
{
"id": 8,
"status": "pass",
"in": {
"text": "봉화로167번길 35-7"
},
"description": "Korean address, there are multiple units at 35-* but none at 35",
"expected": {
"properties": [
{
"housenumber": "35-7",
"street": "봉화로167번길",
"country_a": "KOR"
}
]
}
},
{
"id": "8.1",
"status": "pass",
"in": {
"text": "봉화로167번길 35"
},
"description": "As above, query is for 35 without unit suffix. Sorting is arbitrary.",
"expected": {
"priorityThresh": 10,
"properties": [
{
"housenumber": "35-7",
"street": "봉화로167번길",
"country_a": "KOR"
}
]
}
}
]
}