Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DaemonConnectionException #885

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jan 7, 2025

Use the normal ConnectionException instead of our custom DaemonConnectionException.

@Boy132 Boy132 force-pushed the fix/daemon-exceptions branch from 700baf3 to e67332b Compare January 7, 2025 13:31
@Boy132 Boy132 force-pushed the fix/daemon-exceptions branch from e67332b to 10d542f Compare January 7, 2025 13:38
@RMartinOscar
Copy link
Contributor

RMartinOscar commented Jan 7, 2025

Not a fan of Global Exception if we have an existing type & what we catch only throws one type of exception but i like the use of Repository

Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, read my mind!

@Boy132 Boy132 merged commit c93a836 into pelican-dev:main Jan 7, 2025
15 checks passed
@Boy132 Boy132 deleted the fix/daemon-exceptions branch January 7, 2025 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants