Fix deleting database host when it has assigned nodes #899
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMartinOscar
reviewed
Jan 9, 2025
database/migrations/2025_01_09_143607_database_host_node_foreign_delete_cascade.php
Outdated
Show resolved
Hide resolved
…gn_delete_cascade.php Remove migration rollback Co-authored-by: MartinOscar <[email protected]>
Fix brace position
RMartinOscar
approved these changes
Jan 9, 2025
Boy132
approved these changes
Jan 9, 2025
PseudoResonance
deleted the
fix-delete-database-host-when-assigned-node
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a database host with assigned nodes currently throws a foreign key constraint error. This migration will cascade delete the node assignments as well, but maybe it'd be preferable to just show an error and ask the user to remove the node assignments?