Enable game server ip address allocation for macvlan driver.

[Freddo3000]

This is pterodactyl/wings#203 cherrypicked onto current main branch.

Issue:
For macvlan driver default docker config assign first available ip. Game servers get ip assigned in order of container creation.

Solution proposal:
Wings support only one docker network for each game server. To assign correct IP default allocation could be used. Allocations > doesn't limit IPs at all, admin could set desired game server container ip and port by default allocation.

Tagging @madpeteguy for notice.

[QuintenQVD0]

This seems fine to me. I don't think it would work yet as our config loading order still first loads the default struct

[madpeteguy]

I can test if it will work with pelican.
This would be a good reason for me to switch from pterodactyl.
For my setup this feature is a must, and I'm tired of building own images. Using official ones is more convenient for my homelab cd.

[Freddo3000]

I can test if it will work with pelican. This would be a good reason for me to switch from pterodactyl. For my setup this feature is a must, and I'm tired of building own images. Using official ones is more convenient for my homelab cd.

I've been running it for more than a month now without any noteworthy issue.

[QuintenQVD0]

I can test if it will work with pelican. This would be a good reason for me to switch from pterodactyl. For my setup this feature is a must, and I'm tired of building own images. Using official ones is more convenient for my homelab cd.

I've been running it for more than a month now without any noteworthy issue.

The question is does it still work for people that does not use macvlan.

[madpeteguy]

I can test if it will work with pelican. This would be a good reason for me to switch from pterodactyl. For my setup this feature is a must, and I'm tired of building own images. Using official ones is more convenient for my homelab cd.

I've been running it for more than a month now without any noteworthy issue.

The question is does it still work for people that does not use macvlan.

In short: the proposed change applies only to wings that set docker.network.driver == “macvlan” in the configuration, for standard bridge and host allocations work as before.

The current implementation does not work for an interface of type macvlan, because server containers that connect to this type of network receive the first free IP address from the network pool, so there is no way to determine on which IP the game server will be available (unless we have only one server on this network).

My proposed fix makes the containers assigned to macvlan receive an IP address from the Default Allocation in the server configuration.
If the other allocations are assigned other IP addresses then those IP addresses will be ignored.

It is worth remembering that the use of macvlan has its security downsides, I can describe the ones I know of if necessary.
In addition, port allocations in the case of macvlan are only for informational purposes in the panel, in the network configuration they have no meaning.

Edit:
I am not a GO programmer, but i think this line may not be null safe: var serverNetConfig = config.Get().Docker.Network.
It's worth checking whether there will be a problem in the absence of a docker network configuration.

[QuintenQVD0]

I can test if it will work with pelican. This would be a good reason for me to switch from pterodactyl. For my setup this feature is a must, and I'm tired of building own images. Using official ones is more convenient for my homelab cd.

I've been running it for more than a month now without any noteworthy issue.

The question is does it still work for people that does not use macvlan.

In short: the proposed change applies only to wings that set docker.network.driver == “macvlan” in the configuration, for standard bridge and host allocations work as before.

The current implementation does not work for an interface of type macvlan, because server containers that connect to this type of network receive the first free IP address from the network pool, so there is no way to determine on which IP the game server will be available (unless we have only one server on this network).

My proposed fix makes the containers assigned to macvlan receive an IP address from the Default Allocation in the server configuration. If the other allocations are assigned other IP addresses then those IP addresses will be ignored.

It is worth remembering that the use of macvlan has its security downsides, I can describe the ones I know of if necessary. In addition, port allocations in the case of macvlan are only for informational purposes in the panel, in the network configuration they have no meaning.

Edit: I am not a GO programmer, but i think this line may not be null safe: var serverNetConfig = config.Get().Docker.Network. It's worth checking whether there will be a problem in the absence of a docker network configuration.

The config logic should fil in all fields that are empty and can not be empty

[Crunch41]

@madpeteguy Would you happen to have a pelican build with this fix? Was using your pterodactyl build on unraid but want to move over to pelican & was bummed to find out pelican defaults to the default first available ip same as pterodactyl. Would love to see this officially merged into pelican whenever / if possible.

Edit: Made my own build here https://hub.docker.com/r/crunch41/pelican-wing hope that's alright, Have only tested on unraid but looks like it works as it should now with specified ip addresses being assigned. Only wish you could change the docker container names now haha

[madpeteguy]

@Crunch41 Sorry, I did not have time to migrate to Pelican yet.