Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overlay connection #581

Merged
merged 11 commits into from
Feb 4, 2025
Merged

Improve overlay connection #581

merged 11 commits into from
Feb 4, 2025

Conversation

gianfra-t
Copy link
Contributor

Addresses #580 and #568.

Changes

  • Config can now take an array of node values. It will pick one randomly.
  • Add a timeout and a health check on the receiver side of overlay_conn

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall 👍 I think this might work, let's try it next week.

@pendulum-chain pendulum-chain deleted a comment from ebma Jan 31, 2025
@pendulum-chain pendulum-chain deleted a comment from ebma Jan 31, 2025
@gianfra-t
Copy link
Contributor Author

@ebma the tests seem to have passed except of course the ones that always fail, as it was already failing on the 1.6 PR. I think this could be related to the original issue, hard to tell. Shall we release this first and tackle that later?

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's go.

@gianfra-t gianfra-t merged commit 1a9b488 into main Feb 4, 2025
2 of 4 checks passed
@gianfra-t gianfra-t deleted the improve-overlay-connection branch February 4, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants