Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustls-native-certs with rustls-platform-verifier #1836

Merged

Conversation

rnijveld
Copy link
Member

No description provided.

@rnijveld rnijveld force-pushed the remove-rustls-21-22 branch 9 times, most recently from 537c393 to b91b7bb Compare February 26, 2025 20:06
@rnijveld rnijveld force-pushed the replace-native-cert-with-platform-verifier branch 5 times, most recently from ef89b08 to 42c0d7a Compare February 26, 2025 21:13
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (5a5cb7c) to head (4be5e2a).
Report is 1 commits behind head on remove-rustls-21-22.

Files with missing lines Patch % Lines
nts-pool-ke/src/lib.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           remove-rustls-21-22    #1836      +/-   ##
=======================================================
- Coverage                81.64%   81.62%   -0.03%     
=======================================================
  Files                       68       67       -1     
  Lines                    21945    21920      -25     
=======================================================
- Hits                     17918    17892      -26     
- Misses                    4027     4028       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnijveld rnijveld force-pushed the replace-native-cert-with-platform-verifier branch from 42c0d7a to c9836c5 Compare February 26, 2025 21:18
@rnijveld
Copy link
Member Author

Looks like this runs into https://support.apple.com/en-us/102028

@rnijveld rnijveld force-pushed the replace-native-cert-with-platform-verifier branch 2 times, most recently from 546b076 to 3f83f6d Compare February 27, 2025 09:08
@rnijveld rnijveld force-pushed the remove-rustls-21-22 branch from b91b7bb to 5a5cb7c Compare February 27, 2025 09:16
@rnijveld rnijveld force-pushed the replace-native-cert-with-platform-verifier branch from 3f83f6d to 4be5e2a Compare February 27, 2025 09:17
@rnijveld rnijveld merged commit ca0c891 into remove-rustls-21-22 Feb 27, 2025
20 checks passed
@rnijveld rnijveld deleted the replace-native-cert-with-platform-verifier branch February 27, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants