Refactored clock and filter interfaces. #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidv1992
force-pushed
the
clock-refactor
branch
from
1f97ad5 to
57d489b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 65.41% 65.22% -0.20%
==========================================
Files 48 48
Lines 5257 5271 +14
==========================================
- Hits 3439 3438 -1
- Misses 1818 1833 +15
☔ View full report in Codecov by Sentry. |
davidv1992
force-pushed
the
clock-refactor
branch
from
57d489b to
550d040
Compare
folkertdev
approved these changes
Sep 7, 2023
Comment on lines
+87
to
+90
| /// Get the total amount of seconds | ||
| pub fn seconds(&self) -> f64 { | ||
| self.inner.az::<f64>() / 1e9 | ||
| } |
There was a problem hiding this comment.
given that we use just the one cast (right now) we can possibly inline this at some point. Not a priority though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.