Small fixes to master only mode and the handling of announce messages. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## tai-support #298 +/- ##
===============================================
- Coverage 68.63% 68.54% -0.09%
===============================================
Files 49 49
Lines 5761 5771 +10
===============================================
+ Hits 3954 3956 +2
- Misses 1807 1815 +8
☔ View full report in Codecov by Sentry. |
folkertdev
reviewed
Oct 16, 2023
statime/src/ptp_instance.rs
Outdated
| .filter_map(|port| port.best_local_announce_message()), | ||
| .filter_map(|port| port.best_local_announce_message(true)), |
There was a problem hiding this comment.
it's not really clear here what "true" means. I think an enum should be passed instead here (so Foo::Global)
There was a problem hiding this comment.
or perhaps better, make a best_local_announce_message_global and best_local_announce_message_nonglobal. saves an awkwardly named enum probably
folkertdev
force-pushed
the
tai-support
branch
from
bc98f5e to
9ff1bdf
Compare
davidv1992
force-pushed
the
tai-support
branch
2 times, most recently
from
9fd6418 to
2e5b836
Compare
davidv1992
force-pushed
the
tai-support
branch
from
2e5b836 to
cdaeee9
Compare
davidv1992
force-pushed
the
master-only-refinements
branch
from
1260311 to
1cf2cbe
Compare
folkertdev
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.