Skip to content

Commit

Permalink
Revert "Bump node to 18"
Browse files Browse the repository at this point in the history
  • Loading branch information
AaDalal authored Feb 10, 2024
1 parent 1cfbae0 commit 8039f4f
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
1 change: 0 additions & 1 deletion .github/workflows/shared-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
product: [review, plan, alert]
with:
path: frontend/${{ matrix.product }}
nodeVersion: 18.19.0

publish-frontend:
uses: pennlabs/shared-actions/.github/workflows/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion frontend/alert/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-bookworm
FROM node:10-buster

LABEL maintainer="Penn Labs"

Expand Down
6 changes: 3 additions & 3 deletions frontend/alert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"typescript": "^3.9.5"
},
"scripts": {
"dev": "NODE_OPTIONS=--openssl-legacy-provider node server.js",
"build": "NODE_OPTIONS=--openssl-legacy-provider next build",
"start": "NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production node server.js",
"dev": "node server.js",
"build": "next build",
"start": "NODE_ENV=production node server.js",
"test": "echo no tests yet",
"codecov": "echo no codecov",
"lint": "eslint .",
Expand Down
2 changes: 1 addition & 1 deletion frontend/plan/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-bookworm
FROM node:10-buster

LABEL maintainer="Penn Labs"

Expand Down
4 changes: 2 additions & 2 deletions frontend/plan/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"private": true,
"scripts": {
"dev": "export NODE_OPTIONS=--openssl-legacy-provider && node server.js",
"build": "NODE_OPTIONS=--openssl-legacy-provider next build",
"start": "NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production node server.js",
"build": "next build",
"start": "NODE_ENV=production node server.js",
"test": "echo no tests yet",
"codecov": "echo no codecov",
"lint": "eslint . && tsc --noemit",
Expand Down
2 changes: 1 addition & 1 deletion frontend/review/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-bookworm as build-deps
FROM node:10-buster as build-deps

WORKDIR /app/

Expand Down
6 changes: 3 additions & 3 deletions frontend/review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"workerize-loader": "^1.3.0"
},
"scripts": {
"dev": "NODE_OPTIONS=--openssl-legacy-provider react-scripts start",
"start": "NODE_OPTIONS=--openssl-legacy-provider react-scripts start",
"build": "NODE_OPTIONS=--openssl-legacy-provider react-scripts build",
"dev": "react-scripts start",
"start": "react-scripts start",
"build": "react-scripts build",
"test": "exit 0",
"eject": "react-scripts eject",
"lint": "prettier --check \"src/**/*.js\" && eslint \"./src/**/*.js\"",
Expand Down

0 comments on commit 8039f4f

Please sign in to comment.