Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lukert/gh action patch #704

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Lukert/gh action patch #704

wants to merge 12 commits into from

Conversation

luke-rt
Copy link
Member

@luke-rt luke-rt commented Feb 19, 2025

No description provided.

@luke-rt luke-rt requested a review from joyliu-q February 19, 2025 03:13
./yarn.lock
.tool-versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's tool-versions lol

Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just make sure tool-versions is legit

@julianweng
Copy link
Member

Could be wrong but doesn't your shared actions PR (pennlabs/shared-actions#23) modify the other django check (.github/workflows/build-and-deploy.yaml rather than django-check/action.yaml)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants