-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Sublet Amenity Return Formatting #251
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2497707
Sublet Image Handling
dr-Jess 94b1601
Fix linting whoops
dr-Jess 7df7f2f
Add list comprehensions + prevalidation to images
dr-Jess 315c0c3
Fix misnamed serializer field
dr-Jess 7dd31b3
Fix test cases
dr-Jess a7b4eec
Add separate routes for image creation and deletion
dr-Jess ba8504e
Begin work on sublet testing
dr-Jess fb3e80a
Mocked AWS call
judtinzhang eed33cf
Add tests for multiple images + deletion
dr-Jess 78fc33e
How did this not fail in previous runs haha
dr-Jess f4efde6
Add sublet negotiable, swap max/min to reg price fields
dr-Jess b6eaa20
Fix filtering
dr-Jess 003076d
Merge branch 'master' of github.com:pennlabs/penn-mobile into sublet-…
dr-Jess ca01042
Change amenities return formatting + add comments for sublet/urls
dr-Jess 9f47afd
Alter baths to be 1-point decimal
dr-Jess 19a351c
Fix testing for decimal baths + add testing for new amenities formatting
dr-Jess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 4.2.9 on 2024-03-05 21:16 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("sublet", "0002_auto_20240209_1649"), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name="sublet", | ||
name="baths", | ||
field=models.DecimalField(blank=True, decimal_places=1, max_digits=3, null=True), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we confirm this change by adding an additional check in one of our test cases? Should just be one additional
assert
or something to assert that the type now returned is a list of stringsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! 19a351c checks this by a direct comparison to the expected string list output.