Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed [-1:-1] unexpected end of stream of schema_compiler in LLVM18 OSX #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pentatonick
Copy link
Owner

Fixed ifstream::readsome() returning empty in LLVM18 OSX.

std::basic_istream<CharT,Traits>::readsome is very implementation specific and was returning empty in LLVM18 OSX.

stringstream was used as a in memory stream to allow readsome() to return non-empty

Reference: https://en.cppreference.com/w/cpp/io/basic_istream/readsome

@pentatonick
Copy link
Owner Author

Build failed with:

/home/runner/work/minecpp/minecpp/tool/trace_tool/src/Main.cpp:18:16: error: no member named 'put_time' in namespace 'std'
   return std::put_time(std::localtime(&c_time), "%FT%T%z");

No changes were made to this file since last successful build. Something must have changed in the latest ubuntu update used by the Docker image. I have this file patched locally to compile in OSX but was not needed until this failed build.

Will retry. If fails, will #include <iomanip> // for std::put_time on the failing file in a separate PR.

std::basic_istream<CharT,Traits>::readsome is very implementation specific and was returning empty in LLVM18 OSX.

stringstream was used as a in memory stream to allow readsome() to return non-empty
@pentatonick pentatonick force-pushed the fix-schema-compiler-osx-llvm18 branch from e9903de to 58e3bdd Compare August 8, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant