Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update f4jumble to 0.1.0 #4926

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: update f4jumble to 0.1.0 #4926

merged 1 commit into from
Nov 18, 2024

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Nov 15, 2024

Describe your changes

Updates the old git dependency to a suitable published version from crates.io. To review, see the diff review posted in #4921. I'd prefer that reviewers replicate that work, and confirm that 1) the procedure used for obtaining relevant sources was sound; and 2) the code changes in the dep introduced by this diff are acceptable.

Issue ticket number and link

Refs #4921.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    The dep appears to function the same in pre and post version bump, as does our modified error handling of its return values. Reviewers should confirm those statements are true, and if so, then there's no affect on consensus.

Updates the old git dependency to a suitable published version from
crates.io. Refs #4921.
Copy link
Member

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the diff between revision 2425a0869098e3b0588ccd73c42716bcf418612c and 0.1.0 published on crates.io and agree there aren't changes to the F4Jumble transformation. LGTM

@conorsch conorsch merged commit b252061 into main Nov 18, 2024
14 checks passed
@conorsch conorsch deleted the 4921-f4jumble-update branch November 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants