ci: fix container build for parameter-setup #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built a container from this branch and confirmed build passing. Then I deployed a pindexer instance from that image tag and confirmed the problem described in #4933 was resolved. There's another error emitted now, but at least we've unblocked the image builds, so we're running the latest code again. |
cronokirby
approved these changes
Nov 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up to #4930, in which we inadvertently broken container builds, due to a workspace dependency being introduced. We don't build container images on every PR push, so CI passed fine, only failing when trying to build/deploy post-merge. Tacked on a small change to address.
For testing, leave it to me: I'll re-deploy after this lands to get it going.
Issue ticket number and link
Refs #4933.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: