Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix cargo-release version interpolation #4938

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Updates the package metadata for the parameter-setup crate, which was recently pulled into the workspace. Without these changes, cargo-release was failing to add a version number to the automatically generated commit message.

Issue ticket number and link

Refs #4928, #4930.

Testing and review

If you care to verify the results locally, you can:

git checkout -b my-feature-branch
cargo release 0.80.9 --execute # this won't push anything, but will require cleanup
git show # to view the commit message

Make sure that the generated commit message says "chore: release version 0.80.9", not "chore: release version {{version}}". If you ran these steps, you must clean up:

git checkout main
git tag -d v0.80.9
git branch -D my-feature-branch

If you forget to delete the tag, then when 0.80.9 is actually released, you won't be able to pull the tag from github.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    package metadata only, no changes to application code

Updates the package metadata for the `parameter-setup` crate,
which was recently pulled into the workspace. Without these changes,
`cargo-release` was failing to add a version number to the automatically
generated commit message.

Refs #4928, #4930.
Copy link
Member

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5236,7 +5236,7 @@ dependencies = [

[[package]]
name = "penumbra-parameter-setup"
version = "0.1.0"
version = "0.80.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry about that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I tried to set the version to 0.80.8 explicit, but that didn't resolve the problem. Needed to set version = { workspace = true } and then things were happy again.

@conorsch conorsch merged commit 6d5aea9 into main Nov 21, 2024
14 checks passed
@conorsch conorsch deleted the fix-cargo-release-version-interpolation branch November 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants