Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noble forwarding wasm helpers #1855

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Noble forwarding wasm helpers #1855

merged 4 commits into from
Oct 16, 2024

Conversation

grod220
Copy link
Collaborator

@grod220 grod220 commented Oct 15, 2024

Related to: prax-wallet/prax#206 & penumbra-zone/penumbra#4878

Exposes helpers needed to generate noble forwarding addresess.

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 0816493

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@penumbra-zone/wasm Minor
@penumbra-zone/perspective Major
@penumbra-zone/query Major
@penumbra-zone/services Major
@penumbra-zone/storage Major
minifront Patch
@penumbra-zone/ui Patch
node-status Patch
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@grod220 grod220 requested a review from a team October 15, 2024 13:00
@JasonMHasperhoven
Copy link
Contributor

Recommend that someone else looks at this before merging since I'm not too familiar with rust.

Copy link
Member

@vacekj vacekj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TalDerei TalDerei self-requested a review October 16, 2024 13:47
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasm achieves parity with core implementation

packages/wasm/crate/tests/test_keys.rs Show resolved Hide resolved
@grod220 grod220 merged commit 48725e3 into main Oct 16, 2024
6 checks passed
@grod220 grod220 deleted the noble-forwarding-addr branch October 16, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants