Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for db and core modules #62

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Add some tests for db and core modules #62

merged 2 commits into from
Mar 9, 2020

Conversation

nadege
Copy link
Contributor

@nadege nadege commented Mar 9, 2020

Cf. #29 but there is still work to do

Successful PR Checklist:

  • Tests

@nadege nadege requested a review from ewjoachim March 9, 2020 08:01
@nadege nadege requested review from mgu and samuelhamard as code owners March 9, 2020 08:01
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #62 into master will increase coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   64.93%   67.69%   +2.75%     
==========================================
  Files          14       14              
  Lines         616      616              
  Branches       86       86              
==========================================
+ Hits          400      417      +17     
+ Misses        208      191      -17     
  Partials        8        8              
Flag Coverage Δ
#integration 45.29% <ø> (ø)
#unit 57.62% <ø> (+3.08%) ⬆️
Impacted Files Coverage Δ
septentrion/configuration.py 82.35% <0.00%> (+1.47%) ⬆️
septentrion/db.py 67.18% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224138d...2de465f. Read the comment docs.

@ewjoachim ewjoachim merged commit 46f2ecd into master Mar 9, 2020
@ewjoachim ewjoachim deleted the add-tests branch March 9, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants