Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy explicitly to requirements. #451

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

mknorps
Copy link
Contributor

@mknorps mknorps commented Jul 2, 2023

This PR adds numpy library requirement explicitly to requirements-all.txt.

I am a FawltyDeps (dependency checker for Python projects) maintainer. I took the liberty to check peppy source code with:

fawltydeps --code peppy --deps requirements/requirements-all.txt 

and it looked great ❤️ I see you care a lot about keeping the code clean and reusable. I just found one small problem - that numpy is not declared as a dependency and used explicitly in the code.

I would like to propose the following standard for 3rd party libraries declaration:

If the 3rd party library is explicitly used in the code, it should be explicitly declared in the requirements file.

What do you think about it?

numpy is usually installed along with pandas, but if for some reason you drop pandas or its underlying dependency changes, the code may not work.

@nsheff nsheff changed the base branch from master to dev December 18, 2023 16:01
@nsheff
Copy link
Contributor

nsheff commented Dec 18, 2023

thanks for pointing this out, and fawltydeps sounds useful!

@nsheff nsheff merged commit e7e923d into pepkit:dev Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants