Add numpy
explicitly to requirements.
#451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
numpy
library requirement explicitly to requirements-all.txt.I am a FawltyDeps (dependency checker for Python projects) maintainer. I took the liberty to check
peppy
source code with:and it looked great ❤️ I see you care a lot about keeping the code clean and reusable. I just found one small problem - that
numpy
is not declared as a dependency and used explicitly in the code.I would like to propose the following standard for 3rd party libraries declaration:
What do you think about it?
numpy
is usually installed along withpandas
, but if for some reason you droppandas
or its underlying dependency changes, the code may not work.