Dev 459 sample table index #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e97d3a9.
khoroshevskyi
approved these changes
May 21, 2024
| @@ -302,6 +302,16 @@ def project(self): | |||
| """ | |||
| return self[PRJ_REF] | |||
|
|
|||
| @property | |||
| def sample_name(self): | |||
There was a problem hiding this comment.
Should it be named like sample_name or should it be different property name
Do you have a suggestion @nsheff ?
There was a problem hiding this comment.
Was there another suggestion for this? Otherwise, I will leave it as sample_name.
There was a problem hiding this comment.
I think it's fine. we're kind of locked into that terminology at this point :)
|
I like it. |
nsheff
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #459