Skip to content

Commit

Permalink
v0.5.1 - schema path bug fix (#67)
Browse files Browse the repository at this point in the history
* bug fix schema_path for 0.5.1

* remove unused code

* adjust date on change log

* remove unused summarize code

* update version and changelog
  • Loading branch information
donaldcampbelljr authored Aug 14, 2023
1 parent 9fc39b4 commit 2790bed
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 14 deletions.
5 changes: 5 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) and [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) format.

## [0.5.1] - 2023-08-14
### Fixed

- fix schema_path issue when building html reports and obtaining schema from config file.

## [0.5.0] - 2023-08-08
### Added

Expand Down
2 changes: 1 addition & 1 deletion pipestat/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.5.0"
__version__ = "0.5.1"
4 changes: 0 additions & 4 deletions pipestat/backends/abstract.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,3 @@ def remove_record(
pipeline_type: Optional[str] = None,
) -> bool:
_LOGGER.warning("Not implemented yet for this backend")

def summarize(self) -> None:
_LOGGER.warning("Not implemented yet for this backend")
pass
8 changes: 0 additions & 8 deletions pipestat/backends/filebackend.py
Original file line number Diff line number Diff line change
Expand Up @@ -465,14 +465,6 @@ def set_status(
if prev_status:
_LOGGER.debug(f"Changed status from '{prev_status}' to '{status_identifier}'")

def summarize(self) -> None:
"""
summarize all reported results by building html report
"""
_LOGGER.debug("Make HTML report here")
print("DEBUG SUMMARIZE")
self._htmlreportbuilder()

def _htmlreportbuilder(self):
"""
build html report based on all reported results
Expand Down
2 changes: 1 addition & 1 deletion pipestat/html_reports_pipestat.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def __call__(self, pipeline_name, project_index_html=None, amendment=None):
)
self.prj_index_html_path = project_index_html
self.index_html_path = os.path.join(self.pipeline_reports, "index.html")
schema_path = self.prj.schema_path
schema_path = self.prj._schema_path
self.schema = read_schema(schema_path)[0]
navbar = self.create_navbar(
navbar_links=self.create_navbar_links(
Expand Down
1 change: 1 addition & 0 deletions pipestat/pipestat.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ def process_schema(self, schema_path):
else:
# Main schema
schema_to_read = mk_abs_via_cfg(self._schema_path, self.config_path)
self._schema_path = schema_to_read
parsed_schema = ParsedSchema(schema_to_read)
self[SCHEMA_KEY] = parsed_schema

Expand Down

0 comments on commit 2790bed

Please sign in to comment.