Fix loop over a mutable dict during BGAPI shutdown #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a RuntimeError reported in #306. There's a circular dependency between the backend and device classes. When stopping the BGAPI backend, we call `disconnect` on each device. When a disconnection event is received from the BLED112 adapter, the device is removed from `self._connections` - the same dict we are iterating over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a RuntimeError reported in #306.
There's a circular dependency between the backend and device classes.
When stopping the BGAPI backend, we call
disconnecton each device.When a disconnection event is received from the BLED112 adapter, the
device is removed from
self._connections- the same dict we areiterating over.