Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent Renew - Failure - Not Recovering #137

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

coolhome
Copy link
Contributor

@coolhome coolhome commented Oct 6, 2020

Problem:
User loads application, local storage access token is expired.

oidcCheckAccess is triggered, getUserPromise resolved a user that user.expired is set. authenticateOidcSilent() is triggered which will always resolve regardless of error. In this case my error is login_required from the IdP. The oidcUserManager.getUser() is returning the already loaded user and fails to trigger a full login.

Solution:
Check for expired token during a silent failure and trigger a redirect signin.

Possible fix for #129

@coolhome
Copy link
Contributor Author

coolhome commented Oct 6, 2020

Before fix:
image

After fix:
image

Not sure if this is useful but this was before applying this fix manually.

Here is my file with my logs:
https://gist.github.com/coolhome/1d607dfc02956b4bd987cb5c440c3786

@coolhome
Copy link
Contributor Author

coolhome commented Oct 9, 2020

@perarnborg sorry for rushing but do you think we can get this merged and tagged in a few days?

@perarnborg
Copy link
Owner

perarnborg commented Oct 9, 2020

Yes, I will look at this within short! Sorry I’ve been stretched for time.

@perarnborg perarnborg merged commit cb00115 into perarnborg:master Oct 9, 2020
@perarnborg
Copy link
Owner

OK, looks good. Will publish shortly.

@perarnborg
Copy link
Owner

Published in v3.10.1

@coolhome
Copy link
Contributor Author

coolhome commented Oct 9, 2020

Thanks for help the today @perarnborg greatly appreciate it as always.

@coolhome coolhome deleted the patch-1 branch October 12, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants