EVEREST-1874 | support volume expansion for PXC #688
Conversation
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // StorageClassSupportsVolumeExpansion returns true if the storage class supports volume expansion. | ||
| // If className is unspecified, uses the default storage class | ||
| func StorageClassSupportsVolumeExpansion(c client.Client, ctx context.Context, className *string) (bool, error) { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
context-as-argument: context.Context should be the first parameter of a function (revive)
| return *storageClass.AllowVolumeExpansion, nil | ||
| } | ||
|
|
||
| func getStorageClassOrDefault(c client.Client, ctx context.Context, scName *string) (*storagev1.StorageClass, error) { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
context-as-argument: context.Context should be the first parameter of a function (revive)
| @@ -73,6 +75,63 @@ func (p *applier) AllowUnsafeConfig() { | |||
| } | |||
| } | |||
|
|
|||
| func configureStorage( | |||
| c client.Client, | |||
| ctx context.Context, | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
context-as-argument: context.Context should be the first parameter of a function (revive)
| storageClassDefaultAnnotation = "storageclass.kubernetes.io/is-default-class" | ||
| ) | ||
|
|
||
| // StorageClassSupportsVolumeExpansion returns true if the storage class supports volume expansion. |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Comment should end in a period (godot)
| return &sc, nil | ||
| } | ||
| } | ||
| return nil, fmt.Errorf("no default storage class found") |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
fmt.Errorf can be replaced with errors.New (perfsprint)
CHANGE DESCRIPTION
Problem:
EVEREST-0
Short explanation of the problem.
Related pull requests
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Helm chart
Jira
Tests