Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] EVEREST-1803 Monitoring unavailable in db details widget when specific rule is set #1018

Open
wants to merge 2 commits into
base: rbac-fixes
Choose a base branch
from

Conversation

dianabirs
Copy link
Contributor

@dianabirs dianabirs commented Jan 17, 2025

  • EVEREST-1803
  • removed canUpdateMonitoring from editable condition, as overview monitoring card is related to the db permissions, not the monitoring instance
  • we need to check if db has access to any of the monitoring instances, instead of *, so I moved the logic to the top component, to not load db context with unnecessary computations

@dianabirs dianabirs changed the base branch from main to rbac-fixes January 20, 2025 09:25
@dianabirs dianabirs marked this pull request as ready for review January 20, 2025 09:25
@dianabirs dianabirs requested a review from a team as a code owner January 20, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant