PMM-12468 Mongo plan summary and full scan. #3496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3496 +/- ##
=====================================
Coverage ? 43.63%
=====================================
Files ? 366
Lines ? 44320
Branches ? 0
=====================================
Hits ? 19340
Misses ? 23296
Partials ? 1684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -284,7 +284,7 @@ func TestPerfSchema(t *testing.T) { | |||
| "SELECT * FROM `city`": "9c799bdb2460f79b3423b77cd10403da", | |||
| } | |||
|
|
|||
| case "8.0-oracle", "8.0-percona", "8.4-oracle", "9.0-oracle", "9.1-oracle": | |||
| case "8.0-oracle", "8.0-percona", "8.4-oracle", "9.0-oracle", "9.1-oracle", "9.2-oracle": | |||
There was a problem hiding this comment.
New Oracle version.
JiriCtvrtka
requested review from
ademidoff and
idoqo
and removed request for
a team
|
|
||
| // ExtendedSystemProfile is extended SystemProfile from Percona Toolkit. | ||
| type ExtendedSystemProfile struct { | ||
| proto.SystemProfile `bson:",inline"` |
There was a problem hiding this comment.
Is the comma not a typo here?
There was a problem hiding this comment.
I believe without that proto.SystemProfile properties wont be on same (TOP) level in struct.
Co-authored-by: Alex Demidoff <[email protected]>
…nded.go" This reverts commit 13c3bde.
| @@ -38,7 +38,7 @@ func TestAggregator(t *testing.T) { | |||
| t.Run("Add", func(t *testing.T) { | |||
| t.Run("error if aggregator is not running", func(t *testing.T) { | |||
| a := New(time.Now(), "test-agent", logrus.WithField("component", "test"), truncate.GetMongoDBDefaultMaxQueryLength()) | |||
| err := a.Add(nil, proto.SystemProfile{}) | |||
| err := a.Add(context.TODO(), proto.SystemProfile{}) | |||
There was a problem hiding this comment.
Context should not be nil.
| @@ -237,7 +237,7 @@ func (a *Aggregator) newInterval(ts time.Time) { | |||
| a.timeEnd = a.timeStart.Add(a.d) | |||
| } | |||
|
|
|||
| func (a *Aggregator) createResult(ctx context.Context) *report.Result { | |||
| func (a *Aggregator) createResult(_ context.Context) *report.Result { | |||
…to main_PMM-12468-mongo-plan-summary
|
I will revert changes in go.mod and go.sum files once Percona Toolkit PR is merged. |
|
@ademidoff could you recheck this one, since I moved a lot of code into "Percona Toolkit" repository itself. Thanks. |
PMM-12468
Percona Toolkit PR: percona/percona-toolkit#920
Grafana Dashboards PR: percona/grafana-dashboards#1650
FB: Percona-Lab/pmm-submodules#3832