Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicated PMM2 improvements to HA #3511

Open
wants to merge 6 commits into
base: v3
Choose a base branch
from

Conversation

catalinaadam
Copy link
Contributor

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

-e PMM_CLICKHOUSE_DATABASE=pmm \
-e PMM_CLICKHOUSE_BLOCK_SIZE=10000 \
-e PMM_CLICKHOUSE_POOL_SIZE=2 \
-e PMM_POSTGRESADDR=${PG_HOST_IP}:5432 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be PMM_POSTGRES_ADDR

-e PMM_CLICKHOUSE_BLOCK_SIZE=10000 \
-e PMM_CLICKHOUSE_POOL_SIZE=2 \
-e PMM_POSTGRESADDR=${PG_HOST_IP}:5432 \
-e PMM_POSTGRESUSERNAME=${PG_USERNAME} \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PMM_POSTGRES_USERNAME

-e PMM_CLICKHOUSE_POOL_SIZE=2 \
-e PMM_POSTGRESADDR=${PG_HOST_IP}:5432 \
-e PMM_POSTGRESUSERNAME=${PG_USERNAME} \
-e PMM_POSTGRESDBPASSWORD=${PG_PASSWORD} \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PMM_POSTGRES_DBPASSWORD

-e PMM_CLICKHOUSE_DATABASE=pmm \
-e PMM_CLICKHOUSE_BLOCK_SIZE=10000 \
-e PMM_CLICKHOUSE_POOL_SIZE=2 \
-e PMM_POSTGRESADDR=${PG_HOST_IP}:5432 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for Postgres variables

-e PMM_CLICKHOUSE_BLOCK_SIZE=10000 \
-e PMM_CLICKHOUSE_POOL_SIZE=2 \
-e PMM_POSTGRESADDR=${PG_HOST_IP}:5432 \
-e PMM_POSTGRESUSERNAME=${PG_USERNAME} \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again variables for Postgres

@@ -500,27 +541,27 @@ The PMM Server orchestrates the collection, storage, and visualization of metric
${PMM_DOCKER_IMAGE}
```

=== "Run services on a separate instance"
=== "Run services on a seperate instance"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate

@@ -125,7 +168,7 @@ To set up ClickHouse:
clickhouse/clickhouse-server:23.8.2.7-alpine
```

=== "Run services on a separate instance"
=== "Run services on a seperate instance"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "separate"

@ademidoff ademidoff added the documentation Documentation changes label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants