-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login page initially pointing to blank page #3592
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
- Coverage 42.07% 42.05% -0.03%
==========================================
Files 399 399
Lines 50719 50719
==========================================
- Hits 21342 21328 -14
- Misses 27368 27383 +15
+ Partials 2009 2008 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
README.md
Outdated
@@ -67,7 +67,7 @@ percona/pmm-server:2 | |||
``` | |||
4. Start a web browser and in the address bar enter the server name or IP address of the PMM server host. | |||
|
|||
<img src="https://docs.percona.com/percona-monitoring-and-management/_images/PMM_Login.jpg" width="280"> | |||
<img src="https://docs.percona.com/percona-monitoring-and-management/images/PMM_Login.jpg" width="280"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src="https://docs.percona.com/percona-monitoring-and-management/images/PMM_Login.jpg" width="280"> | |
<img src="./documentation/docs/images/PMM_Login.png" width="280"> |
This image is internal (and many others on this page, btw). Would the above work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, then let's consider https://docs.percona.com/percona-monitoring-and-management/2/images/PMM_Login.jpg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not I initially thought about that solution if the image is internal, unfortunately it was not, I couldn't find the image .png file you are referring to, if you were able to find it then maybe we can go forward with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can find it - https://github.com/percona/pmm/blob/main/documentation/docs/images/PMM_Login.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also the .jpg
version of it - https://github.com/percona/pmm/blob/main/documentation/docs/images/PMM_Login.jpg. You can choose one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think both are the same only but PNG keeps the image sharp as comared to jpg so we can move forward with the PNG one, I still cannot see the PNG file in my VSCode.
I have also made contributions for this README file only do you think maybe I should correct it to use PNG images also?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think both are the same only but PNG keeps the image sharp as comared to jpg so we can move forward with the PNG one, I still cannot see the PNG file in my VSCode. I have also made contributions for this README file only do you think maybe I should correct it to use PNG images also? Thanks
Not sure I understand your environment. If you can open this link in the browser, how come you don't see it on your file system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why this is happening, anyway I can make the necessary changes should I go forward with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Github seems to support all sorts of internal links, so why not?
PNG is more sharp and doesn't compress
@ademidoff after deleting the pmm folder and once again setting up through git I am getting this error:
should I maybe delete the repo and clone it again? |
It seems like you are experiencing a connectivity issue. I suggest you try forking the repo again later. Until that succeeds, you won't be able to push anything. :( As for the other questions, I'd encourage you to post them to the relevant topics on our forum. This will give your questions a much better exposure and a higher chance to get answers. 😉 |
Hey! We will be merging this one as it seems to address the issue 👏 Thanks for your contribution! |
PMM-0
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: