Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login page initially pointing to blank page #3592

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

yashpal2104
Copy link
Contributor

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@yashpal2104 yashpal2104 requested a review from a team as a code owner February 7, 2025 15:58
@yashpal2104 yashpal2104 requested review from BupycHuk and idoqo and removed request for a team February 7, 2025 15:58
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.05%. Comparing base (4d0621e) to head (144d120).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   42.07%   42.05%   -0.03%     
==========================================
  Files         399      399              
  Lines       50719    50719              
==========================================
- Hits        21342    21328      -14     
- Misses      27368    27383      +15     
+ Partials     2009     2008       -1     
Flag Coverage Δ
admin 11.55% <ø> (-0.05%) ⬇️
agent 51.85% <ø> (-0.13%) ⬇️
managed 42.80% <ø> (+<0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
@@ -67,7 +67,7 @@ percona/pmm-server:2
```
4. Start a web browser and in the address bar enter the server name or IP address of the PMM server host.

<img src="https://docs.percona.com/percona-monitoring-and-management/_images/PMM_Login.jpg" width="280">
<img src="https://docs.percona.com/percona-monitoring-and-management/images/PMM_Login.jpg" width="280">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="https://docs.percona.com/percona-monitoring-and-management/images/PMM_Login.jpg" width="280">
<img src="./documentation/docs/images/PMM_Login.png" width="280">

This image is internal (and many others on this page, btw). Would the above work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, then let's consider https://docs.percona.com/percona-monitoring-and-management/2/images/PMM_Login.jpg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not I initially thought about that solution if the image is internal, unfortunately it was not, I couldn't find the image .png file you are referring to, if you were able to find it then maybe we can go forward with this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the .jpg version of it - https://github.com/percona/pmm/blob/main/documentation/docs/images/PMM_Login.jpg. You can choose one of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think both are the same only but PNG keeps the image sharp as comared to jpg so we can move forward with the PNG one, I still cannot see the PNG file in my VSCode.
I have also made contributions for this README file only do you think maybe I should correct it to use PNG images also?
Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@ademidoff ademidoff Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think both are the same only but PNG keeps the image sharp as comared to jpg so we can move forward with the PNG one, I still cannot see the PNG file in my VSCode. I have also made contributions for this README file only do you think maybe I should correct it to use PNG images also? Thanks

Not sure I understand your environment. If you can open this link in the browser, how come you don't see it on your file system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why this is happening, anyway I can make the necessary changes should I go forward with it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Github seems to support all sorts of internal links, so why not?

PNG is more sharp and doesn't compress
@yashpal2104
Copy link
Contributor Author

yashpal2104 commented Feb 7, 2025

@ademidoff after deleting the pmm folder and once again setting up through git I am getting this error:

error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 7679 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

should I maybe delete the repo and clone it again?
Also can I ask on how do I move forward with setting up and contributions, I have selected PBM sdk and PBM backup throttling for GSOC 25 I will be going for 1 of them after setting up the PMM server dashboard on localhost How do I move forward?
I am still yet to setup PMM client I have set up and running PBM agent and PMM server and in the process of PMM client for MongoDB. Any help is appreciated.

@ademidoff
Copy link
Member

ademidoff commented Feb 7, 2025

@ademidoff after deleting the pmm folder and once again setting up through git I am getting this error:

error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 7679 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

should I maybe delete the repo and clone it again? Also can I ask on how do I move forward with setting up and contributions, I have selected PBM sdk and PBM backup throttling for GSOC 25 I will be going for 1 of them after setting up the PMM server dashboard on localhost How do I move forward? I am still yet to setup PMM client I have set up and running PBM agent and PMM server and in the process of PMM client for MongoDB. Any help is appreciated.

It seems like you are experiencing a connectivity issue. I suggest you try forking the repo again later. Until that succeeds, you won't be able to push anything. :(

As for the other questions, I'd encourage you to post them to the relevant topics on our forum. This will give your questions a much better exposure and a higher chance to get answers. 😉

README.md Outdated Show resolved Hide resolved
@ademidoff
Copy link
Member

Hey! We will be merging this one as it seems to address the issue 👏

Thanks for your contribution!

@ademidoff ademidoff merged commit f1b6868 into percona:main Feb 8, 2025
31 checks passed
@yashpal2104 yashpal2104 deleted the pmm-login-docs branch February 8, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants