Harmonize the use of icons in documentation #3593
Draft
+54
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
temporarily deployed
to
docs-harmonize-use-of-icons - pmm-doc-3 PR #3593
Render
Destroyed
ademidoff
force-pushed
the
docs-harmonize-use-of-icons
branch
from
9ebc939 to
2aca001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use far too many icon sets in PMM Documentation.
It would make it much easier for everybody to contribute if there was clarity in terms of which icons should be used where. Therefore, replacing the icons that do not fit or look well with the ones that work much better, reducing the number of icon sets, and, finally, documenting their use with examples would help a lot.
This PR aims at getting rid of the icons defined in
variables.ymlfile and replacing them with the ones from thematerialtheme.Example of a poorly rendered custom inventory icon (renders in black color instead of white, theme-unaware):