PMM-13171 Add ClickHouse credentials #3646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3646 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 367 367
Lines 44538 44553 +15
=======================================
+ Hits 19486 19494 +8
- Misses 23368 23375 +7
Partials 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
ademidoff
commented
Feb 14, 2025
| @@ -138,7 +138,7 @@ | |||
| <!-- Compatibility with MySQL protocol. | |||
| ClickHouse will pretend to be MySQL for applications connecting to this port. | |||
| --> | |||
| <mysql_port>9004</mysql_port> | |||
| <!-- <mysql_port>9004</mysql_port> --> | |||
There was a problem hiding this comment.
We likely don't need to have that many ports open. Please review this.
There was a problem hiding this comment.
we don't use it that way I think - so fair point.
| <allow_plaintext_password>1</allow_plaintext_password> | ||
| <allow_no_password>1</allow_no_password> | ||
| <allow_implicit_no_password>1</allow_implicit_no_password> | ||
| <allow_plaintext_password>0</allow_plaintext_password> |
There was a problem hiding this comment.
This will harden security, for it was too poor before.
BupycHuk
approved these changes
Feb 14, 2025
idoqo
approved these changes
Feb 17, 2025
| @@ -138,7 +138,7 @@ | |||
| <!-- Compatibility with MySQL protocol. | |||
| ClickHouse will pretend to be MySQL for applications connecting to this port. | |||
| --> | |||
| <mysql_port>9004</mysql_port> | |||
| <!-- <mysql_port>9004</mysql_port> --> | |||
There was a problem hiding this comment.
we don't use it that way I think - so fair point.
catalinaadam
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13171
Link to the Feature Build: SUBMODULES-3847