forked from mobolic/facebook-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed put_photo to put_media, now supports photo and video upload #1
Open
percy3d
wants to merge
377
commits into
percy3d:master
Choose a base branch
from
mobolic:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Python 3.4 to tested Python versions. - Run flake8 tests after main test suite.
Update login button permissions in Flask example.
Add new documentation explaining how to use the SDK with Flask (use example), Google App Engine (enable billing), and Tornado (use example). This is stub documentation, so pull requests are welcome!
Update installation instructions so that people stop installing 0.4.0 and then complaining when documentation from the unreleased version from Git does not work.
Convert valid_API_versions to a module-level constant in order to simplify adding new versions by making version tests more dynamic.
Fix formatting of code blocks in installation instructions.
Test cases are based on official Facebook PHP SDK tests: https://github.com/facebookarchive/facebook-php-sdk/blob/master/tests/tests.php Thank you for your hard work!
Do not bother to try checking Python system version, just always use Python 2.6 workaround.
Remove "test_with_only_params" test that no longer worked (it's not possible to query Facebook users by their username). Move remaining tests into new AccessToken test case.
The data that `base64.urlsafe_b64decode` creats are returned as a byte-string in Python 3. We pass this on to `json.loads` which only allows strings, and not byte-strings. So this commit fixes this by decoding data so that it becomes a normal string in Python 3.
Verify that parse_signed_request returns True with valid payload. This avoids the test failing with a confusing TypeError if the cookie is invalid for some reason.
Temporarily comment out `test_function_returns_correct_connections` automated test.
- Install mock package in CircleCI configuration when running tests in Python 2. - Abstract adding a parameter to post_args or args to reduce code duplication between adding access token and application secret proofs. Co-authored-by: Travis Thieman <[email protected]> Co-authored-by: Christian Ledermann <[email protected]> Co-authored-by: Dmytro Litvinov <[email protected]> Co-authored-by: Martey Dodoo <[email protected]>
Co-authored-by: Martey Dodoo <[email protected]>
Use "-m unittest discover" instead of manually calling the `test_facebook` script. This allows us to use the entire `test` directory.
- Reorganize automated tests into multiple files. - Rename test case objects to make it clearer than they inherit from FacebookTestCase. - Remove broken `test_request` test case.
Add `error_subcode` field to GraphAPIError objects if it exists. Close #432. Close #453. Co-authored-by: Martey Dodoo <[email protected]>
- Remove deprecated version 2.10. - Add new version 5.0.
- Remove support for Python 2.7 and 3.4. - Add support for Python 3.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I actually made this change a while ago(about a year ago). I needed to post video. I changed put_photo to put_media.
The method will properly encode the file contents and post it using the appropriate url, either graph.facebook.com or graph-video.facebook.com.
to post a video:
To post a photo:
Thank you for your time.