Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resource reference for hosted zones in AliasTarget #447

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use resource reference for hosted zones in AliasTarget #447

wants to merge 3 commits into from

Conversation

harjain99
Copy link
Contributor

Fixes #446

beetlebugorg
beetlebugorg suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@beetlebugorg beetlebugorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an additional field rather than replace this field. That way this will be backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beetlebugorg beetlebugorg beetlebugorg requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a resource reference for hosted zone in route53 AliasTarget
2 participants
@harjain99 @beetlebugorg