Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit chroot use add run secrects #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atheurer
Copy link
Contributor

@atheurer atheurer commented Dec 5, 2024

No description provided.

@atheurer atheurer added the WIP Work-in-progress label Dec 5, 2024
@atheurer atheurer self-assigned this Dec 5, 2024
- Include /run/secrets in buildah usage
- Eliminate using chroot except req type "source"
  - All of the chroot supportig code moves into the
   'source' req section, a lot of code
  - The "source" type needs chroot because src installs often have chdir
    in some commands and that pwd is not preserved when fedding it
    to 'buildah run'.
  - There may be another req type which still needs chroot method,
    perhaps 'manual'?
-nesting/indetation is still a disaster
@atheurer atheurer force-pushed the limit-chroot-use-add-run-secrects branch from bcafe52 to e7c3352 Compare January 24, 2025 21:00
@atheurer atheurer removed the WIP Work-in-progress label Jan 24, 2025
@atheurer atheurer requested a review from k-rister January 24, 2025 21:01
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're going to have to detect if /run/secrets exists and only map it if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants