-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RawGit is shutting down, replace it with jsDelivr #1185
base: master
Are you sure you want to change the base?
Conversation
I think we should delay merging this for a while as it effects many projects. Hopefully people will confirm these changes work for their use cases. At some point before rawgit closes we'll merge whatever remains to be fixed. |
This PR is ancient and should be closed. |
This PR should be closed. |
I don't think it should be closed but merged - several of the links this fixes are now broken because rawgit has shut down - for instance https://cdn.rawgit.com/dini-ag-kim/movingwall/gh-pages/movingwall.owl no longer works but we know it works with jsdelivr. (Bad example as that has already been fixed!) |
I'd prefer maintainers fix their own things as is appropriate for their project. I'm fine leaving issues like this open until that happens. Probably should re-ping owners of broken links every so often though. |
+1 to closing. Plus, the branch now has conflicts. |
@dgarijo This PR does have issues, but the problem remains. rawgit still hasn't really shut down and some of the patches here could still be applied. I had hope maintainers would update their own redirects because I don't want to do that for them. If anyone has time, perhaps it would help to refresh the related issues with the current problem files and tagging their maintainers. |
@davidlehn @dgarijo one thing that could be done on this repo is adding a CODEOWNERS file, and then all the teams responsible for their areas would be tagged in PRs like this, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners |
@ThisIsMissEm The idea is fine, but in practice, some problems:
I imagine if/when redirects break and someone is still using them, they'll file PRs or issues to get it resolved. So problems will resolve themselves, just sometimes with more panic than was needed. |
RawGit is shutting down. This PR replaces all RawGit links with the recommended alternative - jsDelivr. jsDelivr is a free and fast open source CDN hosting all files from GitHub and npm.
This is an automated PR which is meant to make the migration process as easy as possible. If something doesn't look right or you have any questions, feel free to ping MartinKolarik or jimaek in this PR. You may also use our online migration tool to convert other RawGit links to jsDelivr links.