Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two stage redirection for MIXS terms in gensc namespace #4003

Merged

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Apr 1, 2024

@turbomam
Copy link
Contributor Author

turbomam commented Apr 1, 2024

suggesting review from

@turbomam turbomam changed the title see https://github.com/perma-id/w3id.org/issues/4002 Two stage redirection for MIXS terms in gensc namespace Apr 1, 2024
@sujaypatil96
Copy link
Contributor

sujaypatil96 commented Apr 2, 2024

I agree with the modifications being made in this PR in favor of #3946. However, I wanted to recommend two more redirections from @MattBlissett's original PR.

RewriteRule ^gensc/mixs$ https://w3id.org/mixs [R=302,L]
RewriteRule ^gensc/terms$ https://w3id.org/mixs/term_list/ [R=302,L]

Do you think these might be acceptable redirects @turbomam?

Copy link
Contributor

@sujaypatil96 sujaypatil96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments above as part of this review @turbomam.

@dgarijo
Copy link
Collaborator

dgarijo commented Apr 2, 2024

ping @turbomam

@turbomam
Copy link
Contributor Author

turbomam commented Apr 2, 2024

wanted to recommend two more redirections from @MattBlissett's original PR

Do we have any examples of these URLs already being used in the wild? I would like to strike a balance between

  • ensuring that term-specific URLs in the wild are redirected appropriately
  • not anticipating every way a user could combine gensc, mixs and terms into a URL.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@turbomam
Copy link
Contributor Author

turbomam commented Apr 2, 2024

@ramonawalls please accept or request changes as soon as possible.

A separate issue has been created for the additional requested redirections

@sujaypatil96
Copy link
Contributor

@turbomam the PR looks good! Thank you for separating @MattBlissett's additional requests into a separate issue #4006. This PR is ready to be merged 🚀

@MattBlissett
Copy link
Contributor

@dgarijo, I believe this is just waiting to be merged.

Thanks all,

@dgarijo dgarijo merged commit ddb6fbc into perma-id:master Apr 19, 2024
@davidlehn
Copy link
Collaborator

  • I think this was waiting for approval from the current listed maintainer.
  • @ramonawalls: if the changes here were an issue, please speak up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build upon @MattBlissett 's gensc PR #3946
6 participants