Updated Dockerfile to use the latest Go version 1.22 and added Docker… #292
Conversation
… build and push pipeline
There was a problem hiding this comment.
The workflow there is different from one that I proposed to use as the reference
https://github.com/noble-assets/noble/blob/main/.github/workflows/docker-publish.yaml
If there are any obvious reasons that prevent us from using the same approach, we can discuss those.
docker/persistencecore/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.21.5-alpine3.18 AS go-builder | |||
| FROM golang:1.22.0-alpine3.18 AS go-builder | |||
There was a problem hiding this comment.
Please don't bump Go version, I wrote that we keep on golang:1.21.x until it's upgraded in heighliner there
https://github.com/strangelove-ventures/heighliner/blob/c88e63a992c9cb02c0089e7074acb19248f6fbc7/builder/go_versions.go#L15
| on: | ||
| push: | ||
| branches: | ||
| - 'main' |
There was a problem hiding this comment.
I think we shouldn't push images on docker hub that are not associated with a release.
| platforms: linux/amd64,linux/arm64 | ||
| tags: ${{ env.IMAGE_NAME }}:${{ env.LATEST_VERSION }} | ||
| push: true | ||
| build-args: CONFIG_PATH=./chains.yaml |
There was a problem hiding this comment.
Wait, is it using heighliner?
README.md
Outdated
| @@ -1,143 +1,94 @@ | |||
| # persistenceCore | |||
|  | |||
There was a problem hiding this comment.
Please update the README in a separate PR. Changing CI pipeline for Docker is a functional concern, the README text is non-functional concern, we should separate such things in different PRs.
There was a problem hiding this comment.
Oh, and don't reference JPEGs from 3rd party websites please in any file of the official codebase
|
Heighliner image CI added here - #313 |
… build and push pipeline
1. Overview
2. Implementation details
3. How to test/use
4. Checklist
5. Limitations (optional)
6. Future Work (optional)