Changing how core pods watch the cluster to use Informer() rather tha… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
from
f105f26 to
8b86851
Compare
|
I know this has no tests, I can't figure out how to mock the k8s stuff out and test it. GPT wasn't much help here, either. Open to suggestions! |
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
from
8b86851 to
01c1555
Compare
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
from
01c1555 to
63ab031
Compare
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
2 times, most recently
from
204dc17 to
f28885d
Compare
drcapulet
reviewed
Feb 2, 2024
| // | ||
| // Example pod (scaled up core-1, then scaled it back down): | ||
| // | ||
| // OLD POD NAME OLD POD IP OLD STATUS NEW POD NAME NEW POD IP NEW STATUS |
There was a problem hiding this comment.
Is this just an issue with how Github is rendering this?
There was a problem hiding this comment.
what specifically, the spacing? i did that on purpose so i could read it easier
There was a problem hiding this comment.
Oh sorry I mean that the column names don't line up with the data below AFAICT
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
2 times, most recently
from
abf49bb to
f3226b1
Compare
drcapulet
reviewed
Feb 6, 2024
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
3 times, most recently
from
a2bf992 to
8d1b42e
Compare
kuzmik
force-pushed
the
kuzmik/25/checksum-satellites
branch
from
8d1b42e to
ba97345
Compare
drcapulet
approved these changes
Feb 6, 2024
kuzmik
added a commit
that referenced
this pull request
Feb 8, 2024
Changing how core pods watch the cluster to use Informer() rather tha…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a manual loop