-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add halo2 impl #12
base: main
Are you sure you want to change the base?
Add halo2 impl #12
Conversation
Added halo2 impl! If we mark halo2 stuff as WIP, merging and presenting the halo2 impl shouldn't be a problem |
@DanTehrani I wonder if we should still keep the circom benchmarks on the opening README? So people can quickly understand how useful the project is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as benchmarks end up on front page README, which seems like it'll be handled by the fork where we remove the extraneous PubkeyToAddress()
@vb7401 Thanks for the review!
wdyt? |
|
No description provided.