Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add halo2 impl #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add halo2 impl #12

wants to merge 4 commits into from

Conversation

DanTehrani
Copy link
Member

No description provided.

@DanTehrani
Copy link
Member Author

Added halo2 impl!
The merge conflict is my bad, but it's an easy fix

If we mark halo2 stuff as WIP, merging and presenting the halo2 impl shouldn't be a problem

@DanTehrani DanTehrani requested a review from RiverRuby November 19, 2022 14:11
@RiverRuby
Copy link
Collaborator

@DanTehrani I wonder if we should still keep the circom benchmarks on the opening README? So people can quickly understand how useful the project is?

Copy link
Collaborator

@RiverRuby RiverRuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as benchmarks end up on front page README, which seems like it'll be handled by the fork where we remove the extraneous PubkeyToAddress()

@DanTehrani
Copy link
Member Author

@vb7401 Thanks for the review!
However I’m not really eager to merge this into main right now.

  • The implementation is not complete, and there seems to be some interest in this repo, so we shouldn’t commit incomplete/uncertain things to main.
  • We’re trying out different proving systems and other optimization, so we might completely discard the Halo2 impl in the near future.

wdyt?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants