Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-PAPI] Enhance updated since filter description #192

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[NO-PAPI] Enhance updated since filter description #192

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9fba9b
[NO-PAPI] Enhance updated since filter description
Jun 11, 2024
679dc80
[NO-PAPI] Update end_date description
Jun 12, 2024
4098715
[NO-PAPI] Update end_date description
Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions personio-personnel-data-api-oa3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ paths:
in: query
required: false
description: >2- # indentation is 2 spaces (so code is aligned); strip LF at the end
Filter to select and return only the employees that have been updated after `updated_since`. When it is used together with the `attributes[]` query parameter, the filter will select only the employees that have had any of the provided `attributes[]` updated since `updated_since`. The format is `ISO 8601` (2022-12-24T08:15:30). NOTE: when using the `updated_since` filter, the `email`, `limit`, and `offset` parameters are ignored.
Filter to select and return only the employees that have been updated after `updated_since`. When it is used together with the `attributes[]` query parameter, the filter will select only the employees that have had any of the provided `attributes[]` updated since `updated_since`. The format is `ISO 8601` (2022-12-24T08:15:30) or `YYYY-MM-DD`. NOTE: when using the `updated_since` filter, the `email`, `limit`, and `offset` parameters are ignored.

<details>
<summary><b>Examples with <code>updated_since</code> and <code>attributes[]</code>:</b></summary><br />
Expand Down Expand Up @@ -1934,7 +1934,7 @@ paths:
- name: end_date
in: query
required: false
description: Filter by absence periods that start at or before given date.
description: Filter by absence periods that start at or after given date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is this an intentional change? It should be before, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajki, I fixed the description. It's a bit confusing in terms of which periods are included 😅

schema:
type: string
format: date
Expand Down
Loading