-
Notifications
You must be signed in to change notification settings - Fork 39
Remove deprecated functions (validate_legacy
, hiera_hash
, is_hash
and has_key
)
#99
base: master
Are you sure you want to change the base?
Conversation
Fixes #90 |
validate_legacy
and hiera_hash
)validate_legacy
, hiera_hash
, is_hash
and has_key
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one error in your PR, and puppet-lint -f
will fix the other issues that prevent using this module with puppet 8.
You can take siebrand@d0d18e2 if you like.
manifests/files.pp
Outdated
validate_legacy(String, 'validate_re', $ensure, ['^absent$', '^present$']) | ||
validate_legacy(String, 'validate_string', $swapfile) | ||
Enum['present','absent'] $ensure = 'present', | ||
Stdlib::Absolutefile $swapfile = '/mnt/swap.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Stdlib::Absolutepath. Module with this PR applied throws an error:
Error: Resource type not found: Stdlib::Absolutefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for your feedback. I fixed the reported errors using pdk bundle exec rake lint_fix
(for Puppet8).
Hello, metadata.json requirements for stdlib should be revved to >= 9.6.0 Thaks, -mp |
@mvphilip this module was migrated to Vox Pupuli: https://github.com/voxpupuli/puppet-swap_file |
@kenyon Any idea when it will be published on puppet forge for the first time? |
Since stdlib version 9.x, the
validate_legacy
,is_hash
andhas_key
functions have been deprecated.The
hiera_hash
function is also deprecated (I've replaced it with thelookup
function with the 'hash' merge strategy).