update workflow, codemirror and playwright (#106)

* update workflow checkout and node versions * latest playwright * rebuild yarn * update codemirror * skip some tests on firefox * v0.0.43 * flags for firefox for tests to pass
petersalomonsen · Feb 20, 2025 · a2ee2cb · a2ee2cb
1 parent 361521d
commit a2ee2cb
Show file tree

Hide file tree

Showing 7 changed files with 1,848 additions and 1,364 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -9,7 +9,7 @@ jobs:
     name: Detect use of .only
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Detect use of .only
         run: |
           grep -rq --include '*.spec.js' \.only\( . && echo 'You have .only() in your tests!' && exit 1
@@ -18,7 +18,11 @@ jobs:
     name: Web Test Runner
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
+      - name: Use Node.js 20.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: '20'
       - name: Web Test Runner
         run: |
           sudo apt-get install -y pulseaudio
@@ -33,7 +37,11 @@ jobs:
     name: AssemblyScript synth
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
+      - name: Use Node.js 20.x
+        uses: actions/setup-node@v3
+        with:
+          node-version: '20'
       - name: Assemblyscript synth
         run: |
           cd wasmaudioworklet
@@ -43,7 +51,11 @@ jobs:
     name: Bundle pianorolldemo
     runs-on: ubuntu-latest
     steps:
-        - uses: actions/checkout@v2
+        - uses: actions/checkout@v4
+        - name: Use Node.js 20.x
+          uses: actions/setup-node@v3
+          with:
+            node-version: '20'
         - name: Bundle pianorolldemo
           run: |
             cd wasmaudioworklet
@@ -53,7 +65,11 @@ jobs:
     name: Bundle songcompiler
     runs-on: ubuntu-latest
     steps:
-        - uses: actions/checkout@v2
+        - uses: actions/checkout@v4
+        - name: Use Node.js 20.x
+          uses: actions/setup-node@v3
+          with:
+            node-version: '20'
         - name: Bundle songcompiler
           run: |
             cd wasmaudioworklet

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -8,11 +8,11 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-node@v2
+    - uses: actions/checkout@v4
+    - name: Use Node.js 20.x
+      uses: actions/setup-node@v3
       with:
-        node-version: '18.x'
-        registry-url: 'https://registry.npmjs.org'
+        node-version: '20'
     - run: |
         cd wasmaudioworklet
         export VERSION=`npm view wasm-music dist-tags.latest`

diff --git a/wasmaudioworklet/app.html.js b/wasmaudioworklet/app.html.js
@@ -1,6 +1,6 @@
-export default /*html*/ `<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.48.2/codemirror.min.css">
-<link rel="stylesheet" href="https://codemirror.net/5/addon/dialog/dialog.css">
-<link rel="stylesheet" href="https://codemirror.net/5/addon/lint/lint.css">
+export default /*html*/ `<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/codemirror.min.css">
+<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/dialog/dialog.css">
+<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/lint/lint.css">
 <link rel="stylesheet" type="text/css" href="codemirror-monokai.css">
 <link rel="stylesheet" type="text/css" href="style.css">
 <div id="appcontainer">

diff --git a/wasmaudioworklet/editorcontroller.js b/wasmaudioworklet/editorcontroller.js
@@ -31,15 +31,15 @@ async function loadCodeMirror() {
     await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.55.0/codemirror.min.js');
     await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.55.0/mode/javascript/javascript.js');
 
-    await loadScript('https://codemirror.net/5/addon/search/search.js');
-    await loadScript('https://codemirror.net/5/addon/search/searchcursor.js');
-    await loadScript('https://codemirror.net/5/addon/search/jump-to-line.js');
-    await loadScript('https://codemirror.net/5/addon/dialog/dialog.js');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/search/search.js');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/search/searchcursor.js');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/search/jump-to-line.js');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/dialog/dialog.js');
 
     await loadScript('https://unpkg.com/[email protected]/dist/jshint.js');
-    await loadScript('https://codemirror.net/5/addon/lint/lint.js');
-    await loadScript('https://codemirror.net/5/addon/lint/javascript-lint.js');
-    await loadCSS('https://codemirror.net/5/addon/lint/lint.css');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/lint/lint.js');
+    await loadScript('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/lint/javascript-lint.js');
+    await loadCSS('https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.18/addon/lint/lint.css');
 }
 
 let webassemblySynthUpdated = false;

diff --git a/wasmaudioworklet/package.json b/wasmaudioworklet/package.json
@@ -1,7 +1,7 @@
 {
     "name": "wasm-music",
     "description": "Javascript/WebAssembly live coding environment for music and synthesis",
-    "version": "0.0.42",
+    "version": "0.0.43",
     "repository": {
         "url": "https://github.com/petersalomonsen/javascriptmusic"
     },
@@ -31,9 +31,10 @@
     "devDependencies": {
         "@as-pect/cli": "^8.1.0",
         "@esm-bundle/chai": "^4.3.4-fix.0",
+        "@playwright/test": "^1.50.1",
         "@rollup/plugin-terser": "^0.4.4",
         "@web/rollup-plugin-html": "^2.0.1",
-        "@web/test-runner": "^0.18.0",
+        "@web/test-runner": "^0.20.0",
         "@web/test-runner-playwright": "^0.11.0",
         "assemblyscript": "^0.27.14",
         "chai": "^4.3.7",

diff --git a/wasmaudioworklet/web-test-runner.config.js b/wasmaudioworklet/web-test-runner.config.js
@@ -24,7 +24,12 @@ export default {
       product: 'firefox', launchOptions: {
         headless: false,
         firefoxUserPrefs: {
-          'media.autoplay.block-webaudio': false
+          'media.autoplay.block-webaudio': false,  // Allow Web Audio autoplay
+          'media.autoplay.default': 0,            // Allow autoplay for all media
+          'media.autoplay.allow-extension-background-pages': true,
+          'media.autoplay.blocking_policy': 0,
+          'dom.require_user_interaction_for_audio': false, // Remove user gesture requirement
+          'dom.audiochannel.mutedByDefault': false
         }
       }
     }),