Merge pull request RedHatInsights#936 from petracihalova/rbac-api-fix

RBAC small fixes, unused variables, unreachable code

rbac/api/common/exception_handler.py

@@ -73,7 +73,6 @@ def custom_exception_handler(exc, context):
         error_response = {"errors": errors}
         response.data = error_response
     elif isinstance(exc, IntegrityError):
-        data = context.get("request").data
         source_view = context.get("view")
         response = Response(
             {

rbac/api/openapi/view.py

@@ -19,7 +19,7 @@
 import gzip
 import json
 
-from rest_framework import permissions, status
+from rest_framework import permissions
 from rest_framework.decorators import api_view, permission_classes, renderer_classes
 from rest_framework.renderers import JSONRenderer
 from rest_framework.response import Response
@@ -38,4 +38,3 @@ def openapi(request):
     with gzip.open(openapidoc) as api_file:
         data = json.load(api_file)
         return Response(data)
-    return Response(status=status.HTTP_404_NOT_FOUND)

rbac/api/serializers.py

@@ -57,7 +57,6 @@ def extract_header(request, header):
         Decoded(dict): Identity dictionary
     """
     rh_auth_header = request.META[header]
-    decoded_rh_auth = None
     try:
         decoded_rh_auth = b64decode(rh_auth_header)
     except binascii.Error as err:
@@ -67,7 +66,7 @@ def extract_header(request, header):
         rh_auth_header = add_padding(rh_auth_header)
         decoded_rh_auth = b64decode(rh_auth_header)
     json_rh_auth = json_loads(decoded_rh_auth)
-    return (rh_auth_header, json_rh_auth)
+    return rh_auth_header, json_rh_auth
 
 
 def create_tenant_name(account):