-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use meson built in support for dependency to threads lib #10
Open
JohanSternerup
wants to merge
392
commits into
pexip:tulio/dcsctp
Choose a base branch
from
JohanSternerup:dcsctp_johan
base: tulio/dcsctp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revisit when we do all the final changes around rtpsession and writing of TWCC seqnums.
Be a bit more consistent with how we log ssrcs
ptdemux can't know which of the payloadtypes the lost-event is actually meant for, and taking a guess of it being the "previous" one is going to be wrong in many cases.
And some cleanup/warning fixes.
...it crashes our libvpx...
Need to sort out this mess later on!
It will take the GstVideoRegionOfInterestMeta, and turn one of its specified types into a RTP header-extension. Co-authored-by: Camilo Celis Guzman <[email protected]>
Basically, all frames are "i-frames" here.
Can't have a mix of GstValueArray and GValueArray here.
The state change function will release the lock before emitting the property change event and relock afterwards. This simplifies the flow of calling code dramatically. Co-authored-by: John-Mark Bell <[email protected]>
Co-authored-by: John-Mark Bell <[email protected]>
So we don't have to involve C++ in gst land! Also, link dcsctp statically
to avoid mixing C++ and glib allocators
implemented timeouts single main loop for every sctp association associations lifetime is now only managed by the factory
- to enable aggressive-heartbeat
- renamed gst_sctp_association_start to connect(), to keep consistency with disconnect - handling and logging SctpSocket_Error, closing the socket on error - configure the socket for aggressive-heartbeat, not quite working.. yet!
-lpthread directly just didn't work on my setup. Using the meson built-in dependency seems to be the way other libs do it.
c091d4a
to
393f441
Compare
587ab49
to
87537db
Compare
d4ee89f
to
4b5a3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-lpthread directly just didn't work on my setup.
Using the meson built-in dependency seems to be the way other libs do it.