Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking if the input string while parsing the SAM header is not empty #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r78v10a07
Copy link

@r78v10a07 r78v10a07 commented May 30, 2017

Hi,
I've found some odds BAM files with a TAB at the end of the header lines. I added this check condition to avoid a segmentation fault.
Thanks,
Roberto

@heavywatal
Copy link

Good point. But the large diff because of additional indentation can be avoided by using continue like this:

if (tokenIter->empty()) {continue;}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants