-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACE minor fixes #210
Open
pct960
wants to merge
64
commits into
REL24_Q4
Choose a base branch
from
ace/minor-fixes
base: REL24_Q4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ACE minor fixes #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using hex representation for bytea types in diff file * use correct query for getting cols and pkeys * add a priv check before invoking modules
… /etc/redhat-release file
… and non breaking way
* Fix bytea size check logic
…) & use -download to always create history/out_old
…s for vers. build_to_devel also takes an optional --clean parm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several minor improvements to ACE.
pgpass
file.table-diff
. This was due to a query that was carried over from the very first version of ACE that needed the ACE user to be the table owner. This query has now been updated, and a user with sufficient permissions can performtable-diff
, without having to be the table owner.application_name=ACE
for log auditing purposes.bytea
datatype of a column, ACE will convert it to a hex representation before producing the diff file. It will also short-circuit out oftable-diff
if thebytea
column is too large.table-diff
, all modules needSELECT
.table-repair
needsSELECT
,INSERT
,UPDATE
and optionallyDELETE
.unexpected EOF
errors.table-rerun
.table-rerun
now correctly requests for necessary privileges whenbehavior
ishostdb
, and also properly handles mixed-case table and column names.