Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACE minor fixes #210

Open
wants to merge 64 commits into
base: REL24_Q4
Choose a base branch
from
Open

ACE minor fixes #210

wants to merge 64 commits into from

Conversation

pct960
Copy link
Collaborator

@pct960 pct960 commented Oct 17, 2024

This PR introduces several minor improvements to ACE.

  • If the cluster json file does not have a password specified, ACE will now attempt to read from the pgpass file.
  • When a table does not exist on one of the nodes, ACE will now report that the table is missing instead of reporting that the table name is invalid.
  • Earlier, the ACE user had to be the owner of the table to perform table-diff. This was due to a query that was carried over from the very first version of ACE that needed the ACE user to be the table owner. This query has now been updated, and a user with sufficient permissions can perform table-diff, without having to be the table owner.
  • Added application_name=ACE for log auditing purposes.
  • In the case of a bytea datatype of a column, ACE will convert it to a hex representation before producing the diff file. It will also short-circuit out of table-diff if the bytea column is too large.
  • All ACE modules will now perform a privilege check before attempting to execute any operation. Except table-diff, all modules need SELECT. table-repair needs SELECT, INSERT, UPDATE and optionally DELETE.
  • Multiprocessing worker connection pool lifecycle is now properly handled to avoid unexpected EOF errors.
  • Streamlined sanity checks so that multiple passes on the connection list are no longer needed.
  • Removed redundant checks in table-rerun.
  • table-rerun now correctly requests for necessary privileges when behavior is hostdb, and also properly handles mixed-case table and column names.

luss and others added 30 commits October 16, 2024 10:28
* Using hex representation for bytea types in diff file
* use correct query for getting cols and pkeys
* add a priv check before invoking modules
@pct960 pct960 marked this pull request as ready for review November 21, 2024 23:21
@pct960 pct960 requested a review from cmotyka November 21, 2024 23:26
@pct960 pct960 changed the base branch from REL24_Q4 to REL24_10 November 22, 2024 20:34
@pct960 pct960 changed the base branch from REL24_10 to REL24_Q4 November 22, 2024 20:35
@pct960 pct960 changed the base branch from REL24_Q4 to REL25_01 November 22, 2024 20:52
@pct960 pct960 changed the base branch from REL25_01 to REL24_Q4 November 25, 2024 16:39
@pct960 pct960 changed the base branch from REL24_Q4 to REL25_01 November 25, 2024 16:45
@pct960 pct960 changed the base branch from REL25_01 to REL24_Q4 November 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants