Make sure CMP0148 exists

[lnicola]

Might help building on pre-3.27 CMake like in Debian 12. Not tested.

Reported by @df7cb on Matrix.

@pgRouting/admins

Summary by CodeRabbit

• Chores
  • Updated CMake configuration to improve policy handling robustness
  • Enhanced compatibility with different CMake environments

[coderabbitai]

Walkthrough

The pull request introduces a more robust approach to handling the CMake policy CMP0148 in the CMakeLists.txt file. The changes involve adding a conditional check to ensure the policy is only set when it exists, preventing potential configuration errors in different CMake environments. This modification improves the flexibility and compatibility of the CMake build configuration.

Changes

File	Change Summary
CMakeLists.txt	Added conditional check for CMake policy CMP0148 before setting it to OLD mode

Poem

🐰 A CMake Rabbit's Whisper 🛠️

With policy check, so wise and neat,
Our build config now feels more complete
Conditional magic, a gentle embrace
Preventing errors with algorithmic grace
CMake dancing to a safer tune! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf1d91e and acd9894.

📒 Files selected for processing (1)

• CMakeLists.txt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (1)

CMakeLists.txt (1)

17-19: LGTM! The policy check follows the established pattern.

The conditional check for CMP0148 follows the same pattern as other policy checks in the file, which is the correct approach for maintaining compatibility with older CMake versions.

For verification, let's check the CMake version requirements and policy documentation:

Note: CMP0148 was introduced in CMake 3.27.0 and affects the behavior of file(DOWNLOAD) and file(UPLOAD) commands. The policy determines whether these commands validate certificate name mismatches by default. This change ensures the build works on Debian 12's older CMake version while maintaining the existing behavior.

✅ Verification successful

Verified: Policy check is appropriate defensive programming

The CMP0148 policy check is correctly implemented and necessary because:

• It bridges compatibility between Debian 12's CMake 3.25.1 and newer CMake versions (≥3.27.0)
• It follows the same pattern as other policy checks in the file
• While the codebase currently doesn't use file(DOWNLOAD/UPLOAD) commands, this future-proofs against their potential addition

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify CMake policy CMP0148 details and version requirements

# Check minimum CMake version required by the project
echo "Project's minimum CMake version:"
rg "cmake_minimum_required" -A 1

# Search for other policy-related code for context
echo -e "\nAll policy-related code:"
rg "POLICY CMP" -A 1

# Get CMake version in Debian 12
echo -e "\nDebian 12 CMake version (from packages.debian.org):"
curl -s https://packages.debian.org/bookworm/cmake | grep -o "cmake.*" | grep -o "3[.][0-9]*[.][0-9]*" || echo "Failed to fetch version"

Length of output: 834

---

Script:

#!/bin/bash
# Check if the project uses file(DOWNLOAD) or file(UPLOAD) commands
echo "Searching for file(DOWNLOAD) or file(UPLOAD) usage:"
rg -i "file\s*\(\s*(DOWNLOAD|UPLOAD)" -A 2

Length of output: 157

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[df7cb]

I confirm that the Debian bookworm build is happy again with that patch.

[cvvergara]

@lnicola Can you put the patch also in develop please